Skip to content

Use CountSchedules for counting schedules#3100

Merged
laurakwhit merged 6 commits intomainfrom
count-schedules
Feb 12, 2026
Merged

Use CountSchedules for counting schedules#3100
laurakwhit merged 6 commits intomainfrom
count-schedules

Conversation

@lina-temporal
Copy link
Contributor

Description & motivation 💭

  • Makes use of the incoming CountSchedules API. Using ListWorkflowExecutions to query schedules has always been private API, and it's about to break with the release of CHASM schedules. This makes use of a public API for both V1 and V2 schedules.

@lina-temporal lina-temporal requested review from a team and Alex-Tideman as code owners January 15, 2026 23:23
@vercel
Copy link

vercel bot commented Jan 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
holocene Ready Ready Preview, Comment Feb 12, 2026 0:01am

Request Review

@temporal-cicd
Copy link
Contributor

temporal-cicd bot commented Jan 15, 2026

Warnings
⚠️

📊 Strict Mode: 9 errors in 2 files (0.8% of 1126 total)

src/lib/utilities/route-for-api.ts (8)
  • L67:48: Element implicitly has an 'any' type because type 'typeof globalThis' has no index signature.
  • L73:50: Element implicitly has an 'any' type because type 'typeof globalThis' has no index signature.
  • L75:4: Type 'string | null' is not assignable to type 'string'.
  • L102:8: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type '{ namespace: string; workflowId: string; scheduleId: string; queue: string; queryType: string; signalName: string; updateName: string; batchJobId: string; runId: string; activityId: string; endpointId: string; deploymentName: string; version: string; }'.
  • L102:38: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type 'Partial'.
  • L104:8: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type '{ namespace: string; workflowId: string; scheduleId: string; queue: string; queryType: string; signalName: string; updateName: string; batchJobId: string; runId: string; activityId: string; endpointId: string; deploymentName: string; version: string; }'.
  • L104:57: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type 'Partial'.
  • L187:16: This overload signature is not compatible with its implementation signature.
src/lib/services/workflow-counts.ts (1)
  • L34:3: Function lacks ending return statement and return type does not include 'undefined'.

Generated by 🚫 dangerJS against 4f9ce18

@lina-temporal lina-temporal marked this pull request as draft January 28, 2026 01:44
Older servers that predate the CountSchedules API (added in
v1.62.0) return 404 instead of 501. Treat both status codes
as a signal to use the legacy workflow-count-based path.
@laurakwhit laurakwhit merged commit 02b30a6 into main Feb 12, 2026
17 checks passed
@laurakwhit laurakwhit deleted the count-schedules branch February 12, 2026 16:35
temporal-cicd bot pushed a commit that referenced this pull request Feb 23, 2026
Auto-generated version bump from 2.45.3 to 2.45.4

Bump type: patch

Changes included:
- [`02b30a6e`](02b30a6) Use CountSchedules for counting schedules (#3100)
- [`90dfec88`](90dfec8) Add fallbacks for activities routes (#3154)
- [`f160628c`](f160628) DT-3564 - migrate schedules form to superforms (#3159)
- [`50d7bdf3`](50d7bdf) small css changes to nav components for better responsiveness (#3162)
- [`e3b4028b`](e3b4028) UI Copy Updates (#3165)
- [`3638919c`](3638919) add snippet for pre-release badge on standalone activities page (#3166)
- [`1ee50fcb`](1ee50fc) fix standalone activity routes and prep for release (#3168)
- [`7553e5b4`](7553e5b) Event history legend (#3160)
- [`562067a8`](562067a) Environment variable audit (#3163)
- [`51bdfd75`](51bdfd7) Card typography fixes (#3169)
- [`dfc6b453`](dfc6b45) fix schedule edit form infinite effect loop (#3172)
- [`07995e61`](07995e6) fix infinite effect bug when editing schedule with large input payload (#3174)
rossedfort added a commit that referenced this pull request Feb 23, 2026
Auto-generated version bump from 2.45.3 to 2.45.4

Bump type: patch

Changes included:
- [`02b30a6e`](02b30a6) Use CountSchedules for counting schedules (#3100)
- [`90dfec88`](90dfec8) Add fallbacks for activities routes (#3154)
- [`f160628c`](f160628) DT-3564 - migrate schedules form to superforms (#3159)
- [`50d7bdf3`](50d7bdf) small css changes to nav components for better responsiveness (#3162)
- [`e3b4028b`](e3b4028) UI Copy Updates (#3165)
- [`3638919c`](3638919) add snippet for pre-release badge on standalone activities page (#3166)
- [`1ee50fcb`](1ee50fc) fix standalone activity routes and prep for release (#3168)
- [`7553e5b4`](7553e5b) Event history legend (#3160)
- [`562067a8`](562067a) Environment variable audit (#3163)
- [`51bdfd75`](51bdfd7) Card typography fixes (#3169)
- [`dfc6b453`](dfc6b45) fix schedule edit form infinite effect loop (#3172)
- [`07995e61`](07995e6) fix infinite effect bug when editing schedule with large input payload (#3174)

Co-authored-by: rossedfort <11775628+rossedfort@users.noreply.github.com>
@laurakwhit laurakwhit mentioned this pull request Feb 27, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants